Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(prism-agent): fix credential schema parsing as spec #841

Merged
merged 5 commits into from
Jan 15, 2024
Merged

fix(prism-agent): fix credential schema parsing as spec #841

merged 5 commits into from
Jan 15, 2024

Conversation

bvoiturier
Copy link
Contributor

Overview

Checklist

My PR contains...

  • No code changes (changes to documentation, CI, metadata, etc.)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes
  • are not breaking changes
  • If yes to above: I have updated the documentation accordingly

Documentation

  • My changes do not require a change to the project documentation
  • My changes require a change to the project documentation
  • If yes to above: I have updated the documentation accordingly

Tests

  • My changes can not or do not need to be tested
  • My changes can and should be tested by unit and/or integration tests
  • If yes to above: I have added tests to cover my changes
  • If yes to above: I have taken care to cover edge cases in my tests

@bvoiturier
fix(prism-agent): parse dereferenced JWT or AnonCreds credential sche…
22e3f8d 
…mas according to the spec instead of OEA proprietary format

Signed-off-by: Benjamin Voiturier <[email protected]>
@bvoiturier
fix(prism-agent): fallback to OEA proprietary format for JWT VC schem…
fb1592d 
…a when spec-format parsing fails

Signed-off-by: Benjamin Voiturier <[email protected]>
@bvoiturier bvoiturier requested a review from yshyn-iohk January 12, 2024 15:14
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited
Loading

Unit Test Results

 87 files  ±0   87 suites  ±0   20m 53s ⏱️ -23s
725 tests ±0  717 ✅ ±0  8 💤 ±0  0 ❌ ±0 
735 runs  ±0  727 ✅ ±0  8 💤 ±0  0 ❌ ±0 

Results for commit 9af14ab. ± Comparison against base commit 214b36a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 12, 2024 •
edited
Loading

Integration Test Results

11 files  ±0  11 suites  ±0   2s ⏱️ ±0s
24 tests ±0  24 ✅ ±0  0 💤 ±0  0 ❌ ±0 
25 runs  ±0  25 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9af14ab. ± Comparison against base commit 214b36a.

♻️ This comment has been updated with latest results.

@bvoiturier
chore(pollux): run scalafmtAll
83d90c4 
Signed-off-by: Benjamin Voiturier <[email protected]>
@bvoiturier bvoiturier changed the title Fix/credential schema parsing as spec fix(prism-agent): fix credential schema parsing as spec Jan 15, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bvoiturier bvoiturier merged commit 6f897ce into feat/ZKP-verification Jan 15, 2024
11 checks passed
@bvoiturier bvoiturier deleted the fix/credential-schema-parsing-as-spec branch January 15, 2024 08:13
CryptoKnightIOG pushed a commit that referenced this pull request Jan 24, 2024
@bvoiturier @CryptoKnightIOG
fix(prism-agent): fix credential schema parsing as spec (#841)
06d8e86 
Signed-off-by: Benjamin Voiturier <[email protected]>
CryptoKnightIOG pushed a commit that referenced this pull request Feb 1, 2024
@bvoiturier @CryptoKnightIOG
fix(prism-agent): fix credential schema parsing as spec (#841)
43df718 
Signed-off-by: Benjamin Voiturier <[email protected]>
CryptoKnightIOG pushed a commit that referenced this pull request Feb 1, 2024
@bvoiturier @CryptoKnightIOG
fix(prism-agent): fix credential schema parsing as spec (#841)
2ec1997 
Signed-off-by: Benjamin Voiturier <[email protected]>
CryptoKnightIOG pushed a commit that referenced this pull request Feb 1, 2024
@bvoiturier @CryptoKnightIOG
fix(prism-agent): fix credential schema parsing as spec (#841)
2da8c5a 
Signed-off-by: Benjamin Voiturier <[email protected]>
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG pushed a commit that referenced this pull request Feb 2, 2024
@bvoiturier @CryptoKnightIOG
fix(prism-agent): fix credential schema parsing as spec (#841)
7d304d2 
Signed-off-by: Benjamin Voiturier <[email protected]>
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG pushed a commit that referenced this pull request Feb 3, 2024
@bvoiturier @CryptoKnightIOG
fix(prism-agent): fix credential schema parsing as spec (#841)
fb34dc2 
Signed-off-by: Benjamin Voiturier <[email protected]>
CryptoKnightIOG pushed a commit that referenced this pull request Feb 9, 2024
@bvoiturier @CryptoKnightIOG
fix(prism-agent): fix credential schema parsing as spec (#841)
b4ef6da 
Signed-off-by: Benjamin Voiturier <[email protected]>
CryptoKnightIOG pushed a commit that referenced this pull request Feb 9, 2024
@bvoiturier @CryptoKnightIOG
fix(prism-agent): fix credential schema parsing as spec (#841)
d061dd5 
Signed-off-by: Benjamin Voiturier <[email protected]>
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG pushed a commit that referenced this pull request Feb 18, 2024
@bvoiturier @CryptoKnightIOG
fix(prism-agent): fix credential schema parsing as spec (#841)
883c829 
Signed-off-by: Benjamin Voiturier <[email protected]>
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG pushed a commit that referenced this pull request Feb 23, 2024
@bvoiturier @CryptoKnightIOG
fix(prism-agent): fix credential schema parsing as spec (#841)
0b3194f 
Signed-off-by: Benjamin Voiturier <[email protected]>
Signed-off-by: Bassam Riman <[email protected]>
CryptoKnightIOG pushed a commit that referenced this pull request Feb 28, 2024
@bvoiturier @CryptoKnightIOG
fix(prism-agent): fix credential schema parsing as spec (#841)
8439de4 
Signed-off-by: Benjamin Voiturier <[email protected]>
Signed-off-by: Bassam Riman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

@patlo-iog patlo-iog Awaiting requested review from patlo-iog

@CryptoKnightIOG CryptoKnightIOG Awaiting requested review from CryptoKnightIOG

@mineme0110 mineme0110 Awaiting requested review from mineme0110

@antonbaliasnikov antonbaliasnikov Awaiting requested review from antonbaliasnikov

Assignees
No one assigned
Labels
pollux prism-agent
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bvoiturier @yshyn-iohk @atala-dev